Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rules for preferences for true/false/null #359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

osamayelk
Copy link
Contributor

Description

Added new rules for prefer toBeNull/toBeTrue/toBeFalse. This implements the enhancement #352
We could discuss whether or not we need rules to prefer toBeTrue/toBeFalse over toBeTruthy/toBeFalsy and what should we call them.

How has this been tested?

I wrote mocha tests following the same pattern for toBeUndefined

Types of changes

  • Test change (non-breaking change which adds additional test scenarios)
  • Refactor change (non-breaking change updates coding styles)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have ran npm run test and everything passes
  • My code follows the code style of this project
  • I have updated the documentation where necessary
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests pass

@pullard
Copy link

pullard commented Apr 12, 2023

Sounds like a great addition, is this being looked at?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants