-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(notary): implement timeout for notarization #639
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #639 +/- ##
==========================================
+ Coverage 54.32% 54.35% +0.03%
==========================================
Files 192 192
Lines 20486 20474 -12
==========================================
Hits 11129 11129
+ Misses 9357 9345 -12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but lets move this timeout into config
Putting a timeout for each notarization task to prevent it from hanging when prover doesn't notify notary to stop or err; else it might lead to unreleased memory piling up