Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tlsn): mpz upgrade #512

Merged
merged 2 commits into from
Jun 25, 2024
Merged

refactor(tlsn): mpz upgrade #512

merged 2 commits into from
Jun 25, 2024

Conversation

sinui0
Copy link
Member

@sinui0 sinui0 commented Jun 21, 2024

This PR updates tlsn crates to integrate the mpz upgrade.

note: cherry pick #499 to run integration tests

Changes

  1. Switch to using serio and new uid-mux, clean up IO code including better error handling. This should also remove any potential race conditions that may occur from the remote peer closing.
  2. As changed in refactor(universal-hash): mpz upgrade #502 we no longer reveal the MAC key to the verifier
  3. tracing is always on
  4. Added force-st feature to tlsn-prover and tlsn-verifier which forces single threaded execution (disables rayon)
  5. We no longer allocate OTs for key exchange / GHASH upfront, it's handled downstream refactor(key-exchange): mpz upgrade #496 refactor(universal-hash): mpz upgrade #502
  6. Added some type aliases in tlsn-common to reduce noise

@sinui0 sinui0 requested review from themighty1 and th4s June 21, 2024 06:25
@sinui0 sinui0 force-pushed the refactor/mpz-upgrade-tlsn branch from 3ef0b96 to a7d45fd Compare June 21, 2024 06:34
@themighty1
Copy link
Member

@sinui0 , I think the conflicts need to be resolved. i cant load up this branch into vscode currently.

Base automatically changed from refactor/mpz-upgrade-tls-mpc to mpz-upgrade June 24, 2024 16:21
@sinui0 sinui0 force-pushed the refactor/mpz-upgrade-tlsn branch from a7d45fd to d9bc9e8 Compare June 24, 2024 19:36
@sinui0
Copy link
Member Author

sinui0 commented Jun 24, 2024

@themighty1 can you elaborate? Merge conflicts don't prevent you from checking out the branch

@sinui0 sinui0 force-pushed the refactor/mpz-upgrade-tlsn branch from d9bc9e8 to 80b258d Compare June 24, 2024 20:44
Copy link
Member

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!!! i left some non-blocking qs

tlsn/tlsn-common/src/mux.rs Show resolved Hide resolved
tlsn/tlsn-prover/src/tls/mod.rs Show resolved Hide resolved
tlsn/tlsn-prover/src/tls/notarize.rs Show resolved Hide resolved
tlsn/tlsn-prover/src/tls/prove.rs Show resolved Hide resolved
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🚀 🚀

tlsn/tlsn-common/Cargo.toml Outdated Show resolved Hide resolved
@sinui0 sinui0 merged commit 3eec67b into mpz-upgrade Jun 25, 2024
@sinui0 sinui0 deleted the refactor/mpz-upgrade-tlsn branch June 25, 2024 17:47
sinui0 added a commit that referenced this pull request Jun 25, 2024
* refactor(tlsn): mpz upgrade

* PR feedback
sinui0 added a commit that referenced this pull request Jun 25, 2024
* refactor(tlsn): mpz upgrade

* PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants