Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restructure notary crates #508

Merged
merged 12 commits into from
Jun 25, 2024
Merged

Conversation

yuroitaki
Copy link
Member

Relocate notary client crate into a notary folder that is restructured to contain the client, server and integration test crates — the downstream impacts are generally just

  • examples
  • CD and GH action

@yuroitaki yuroitaki requested review from heeckhau and sinui0 June 19, 2024 11:47
Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We'll have to update the docs too when we release

Copy link
Contributor

@ntampakas ntampakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i mainly checked for typos

.github/workflows/cd-server.yml Outdated Show resolved Hide resolved
.github/workflows/cd.yml Outdated Show resolved Hide resolved
notary/server/README.md Outdated Show resolved Hide resolved
yuroitaki and others added 3 commits June 24, 2024 14:43
Co-authored-by: dan <themighty1@users.noreply.github.com>
Co-authored-by: dan <themighty1@users.noreply.github.com>
@yuroitaki yuroitaki requested a review from themighty1 June 24, 2024 07:03
@sinui0 sinui0 changed the title Restructure notary crates refactor: restructure notary crates Jun 25, 2024
@yuroitaki yuroitaki merged commit c80b440 into dev Jun 25, 2024
15 checks passed
@yuroitaki yuroitaki deleted the chore/relocate-notary-client branch June 25, 2024 02:34
@yuroitaki yuroitaki mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants