Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(prf): mpz upgrade #497

Merged
merged 3 commits into from
Jun 14, 2024
Merged

refactor(prf): mpz upgrade #497

merged 3 commits into from
Jun 14, 2024

Conversation

sinui0
Copy link
Member

@sinui0 sinui0 commented Jun 12, 2024

This PR updates our prf crate to use the new mpz API.

Note: The exact commit of mpz is not settled yet, we will update this prior to release.

Changes

  • A bit of general clean up including making the error type opaque
  • Utilizes the preprocessing API from mpz to preprocess the prf as much as possible prior to the online phase.
  • The PRF verify data was switched to being public, which should cut down on latency due to not needing OTPs.

@sinui0 sinui0 requested review from themighty1 and th4s June 12, 2024 01:23
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Shouldn't we adapt the Prf trait to reflect that cfvd and sfvd are no longer private?

components/prf/hmac-sha256/src/prf.rs Show resolved Hide resolved
@sinui0 sinui0 force-pushed the refactor/mpz-upgrade-prf branch from 4bd10e7 to 006c70a Compare June 12, 2024 19:53
@sinui0 sinui0 changed the base branch from refactor/mpz-upgrade-key-exchange to mpz-upgrade June 12, 2024 19:53
Copy link
Member

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gw! some changes may be needed.

components/prf/hmac-sha256/src/lib.rs Outdated Show resolved Hide resolved
components/prf/hmac-sha256/src/prf.rs Outdated Show resolved Hide resolved
components/prf/hmac-sha256/src/prf.rs Outdated Show resolved Hide resolved
sinui0 and others added 2 commits June 13, 2024 11:43
Co-authored-by: dan <themighty1@users.noreply.github.com>
@sinui0 sinui0 requested a review from themighty1 June 13, 2024 18:44
@sinui0 sinui0 merged commit a1deba1 into mpz-upgrade Jun 14, 2024
@sinui0 sinui0 deleted the refactor/mpz-upgrade-prf branch June 14, 2024 07:47
sinui0 added a commit that referenced this pull request Jun 25, 2024
* refactor(prf): mpz upgrade

* consolidate vd methods

* Update components/prf/hmac-sha256/src/lib.rs

Co-authored-by: dan <themighty1@users.noreply.github.com>

---------

Co-authored-by: dan <themighty1@users.noreply.github.com>
sinui0 added a commit that referenced this pull request Jun 25, 2024
* refactor(prf): mpz upgrade

* consolidate vd methods

* Update components/prf/hmac-sha256/src/lib.rs

Co-authored-by: dan <themighty1@users.noreply.github.com>

---------

Co-authored-by: dan <themighty1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants