Interactive verifier #379
Merged
Interactive verifier #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinui0
requested changes
Oct 31, 2023
sinui0
requested changes
Nov 3, 2023
sinui0
requested changes
Nov 3, 2023
This was referenced Nov 7, 2023
Merged
th4s
force-pushed
the
interactive-verifier
branch
from
23cedd3 to
0df63b7
Compare
th4s
force-pushed
the
interactive-verifier
branch
from
1608645 to
955ec80
Compare
|
should be able to rebase on dev now |
|
it is already. |
`SessionData` for interactive verifier flow
`ServerInfo` is generated by `SessionData` and is the non-notarization version of `SessionProof`
th4s
force-pushed
the
interactive-verifier
branch
from
0a300d7 to
7d4a727
Compare
sinui0
requested changes
Dec 1, 2023
themighty1
added a commit
to themighty1/tlsn
that referenced
this pull request
Jan 4, 2024
* Added necessary state and state transitions * Move Prover future into its own module * Put phase-specific prover code into its own modules * Make `ProverFuture` public again * Added `Into` from `Closed` to `Verify` for `Prover` state transition * Added first part of finalize method for `Prover<Verify>` * Rename `SessionData` to `NotarizedSessionData` and introduce `SessionData` for interactive verifier flow * Added first sketches for HttpProver and Prover with Verifier state * Introduced wrapper `ServerInfo` `ServerInfo` is generated by `SessionData` and is the non-notarization version of `SessionProof` * Crate `ServerInfo` from `SessionData` in Prover<Verify> flow * Introduced another module for direct substring proofs. * WIP: Added dirty first version of prover flow... * Move `RangeCollector` and restore substring module * Tidy up tlsn-core and finish first version of prover flow for dealing with a verifier * Refactored verifier * Added `Verify` state for `Verifier` * WIP: Added first draft for verify flow... * Added more parts of verifier flow * Adapt tests to new api changes * Add some logging and improve code here and there * Added `ProofBuilder` trait and started implementing it for `SubstringsProofBuilder` * WIP: Tinkering with lifetimes... * Resolved lifetime issues * Refactor module `proof` to support another implementor of `SubstringProofBuilder` * WIP: Adding `LabelProofBuilder`... * Streamlined api * Improved decoding flow * Include lengths in `LabelProof` * Improved structure of `LabelProof` and finished `verify` * Added integration test for verify flow * Add tests for `LabelProof` * Improve test for `LabelProof::verify` * Make tlsn compile without `tlsn-formats` * Restore `tlsn-formats` from `dev` and temporarily remove from workspace * Add first batch of feedback * Add further feedback * Separated decoding from finalization * Add warning comment to `Verifier::receive` * Remove unnecessary traits * Adapt test * Repair notarize integration test * Add `decode` call to prover for verify integration test * Simplified `LabelProof` and renamed to `TranscriptProof` * Add range check to `reconstruct` * Roll back changes to `tlsn-prover/src/http` * Rename `Verify` to `Prove` * Added more feedback * Various code improvements * Remove `SessionData` * Restore naming of `TlsProof` and `SessionData` * Improve error handling * Adapt prove-verify flow to new API * Finalize VM first * Fix prover closing connection too early * Add correct server certificate and assert correct redactions * Fix imports after rebase * Fix api test in `tlsn-core` * Add feedback * Fix linting in integration test Co-authored-by: th4s <th4s@metavoid.xyz>
th4s
added a commit
that referenced
this pull request
Jan 9, 2024
* Added necessary state and state transitions * Move Prover future into its own module * Put phase-specific prover code into its own modules * Make `ProverFuture` public again * Added `Into` from `Closed` to `Verify` for `Prover` state transition * Added first part of finalize method for `Prover<Verify>` * Rename `SessionData` to `NotarizedSessionData` and introduce `SessionData` for interactive verifier flow * Added first sketches for HttpProver and Prover with Verifier state * Introduced wrapper `ServerInfo` `ServerInfo` is generated by `SessionData` and is the non-notarization version of `SessionProof` * Crate `ServerInfo` from `SessionData` in Prover<Verify> flow * Introduced another module for direct substring proofs. * WIP: Added dirty first version of prover flow... * Move `RangeCollector` and restore substring module * Tidy up tlsn-core and finish first version of prover flow for dealing with a verifier * Refactored verifier * Added `Verify` state for `Verifier` * WIP: Added first draft for verify flow... * Added more parts of verifier flow * Adapt tests to new api changes * Add some logging and improve code here and there * Added `ProofBuilder` trait and started implementing it for `SubstringsProofBuilder` * WIP: Tinkering with lifetimes... * Resolved lifetime issues * Refactor module `proof` to support another implementor of `SubstringProofBuilder` * WIP: Adding `LabelProofBuilder`... * Streamlined api * Improved decoding flow * Include lengths in `LabelProof` * Improved structure of `LabelProof` and finished `verify` * Added integration test for verify flow * Add tests for `LabelProof` * Improve test for `LabelProof::verify` * Make tlsn compile without `tlsn-formats` * Restore `tlsn-formats` from `dev` and temporarily remove from workspace * Add first batch of feedback * Add further feedback * Separated decoding from finalization * Add warning comment to `Verifier::receive` * Remove unnecessary traits * Adapt test * Repair notarize integration test * Add `decode` call to prover for verify integration test * Simplified `LabelProof` and renamed to `TranscriptProof` * Add range check to `reconstruct` * Roll back changes to `tlsn-prover/src/http` * Rename `Verify` to `Prove` * Added more feedback * Various code improvements * Remove `SessionData` * Restore naming of `TlsProof` and `SessionData` * Improve error handling * Adapt prove-verify flow to new API * Finalize VM first * Fix prover closing connection too early * Add correct server certificate and assert correct redactions * Fix imports after rebase * Fix api test in `tlsn-core` * Add feedback * Fix linting in integration test
th4s
added a commit
that referenced
this pull request
Jan 10, 2024
* Added necessary state and state transitions * Move Prover future into its own module * Put phase-specific prover code into its own modules * Make `ProverFuture` public again * Added `Into` from `Closed` to `Verify` for `Prover` state transition * Added first part of finalize method for `Prover<Verify>` * Rename `SessionData` to `NotarizedSessionData` and introduce `SessionData` for interactive verifier flow * Added first sketches for HttpProver and Prover with Verifier state * Introduced wrapper `ServerInfo` `ServerInfo` is generated by `SessionData` and is the non-notarization version of `SessionProof` * Crate `ServerInfo` from `SessionData` in Prover<Verify> flow * Introduced another module for direct substring proofs. * WIP: Added dirty first version of prover flow... * Move `RangeCollector` and restore substring module * Tidy up tlsn-core and finish first version of prover flow for dealing with a verifier * Refactored verifier * Added `Verify` state for `Verifier` * WIP: Added first draft for verify flow... * Added more parts of verifier flow * Adapt tests to new api changes * Add some logging and improve code here and there * Added `ProofBuilder` trait and started implementing it for `SubstringsProofBuilder` * WIP: Tinkering with lifetimes... * Resolved lifetime issues * Refactor module `proof` to support another implementor of `SubstringProofBuilder` * WIP: Adding `LabelProofBuilder`... * Streamlined api * Improved decoding flow * Include lengths in `LabelProof` * Improved structure of `LabelProof` and finished `verify` * Added integration test for verify flow * Add tests for `LabelProof` * Improve test for `LabelProof::verify` * Make tlsn compile without `tlsn-formats` * Restore `tlsn-formats` from `dev` and temporarily remove from workspace * Add first batch of feedback * Add further feedback * Separated decoding from finalization * Add warning comment to `Verifier::receive` * Remove unnecessary traits * Adapt test * Repair notarize integration test * Add `decode` call to prover for verify integration test * Simplified `LabelProof` and renamed to `TranscriptProof` * Add range check to `reconstruct` * Roll back changes to `tlsn-prover/src/http` * Rename `Verify` to `Prove` * Added more feedback * Various code improvements * Remove `SessionData` * Restore naming of `TlsProof` and `SessionData` * Improve error handling * Adapt prove-verify flow to new API * Finalize VM first * Fix prover closing connection too early * Add correct server certificate and assert correct redactions * Fix imports after rebase * Fix api test in `tlsn-core` * Add feedback * Fix linting in integration test
themighty1
added a commit
that referenced
this pull request
Jan 10, 2024
* Added necessary state and state transitions * Move Prover future into its own module * Put phase-specific prover code into its own modules * Make `ProverFuture` public again * Added `Into` from `Closed` to `Verify` for `Prover` state transition * Added first part of finalize method for `Prover<Verify>` * Rename `SessionData` to `NotarizedSessionData` and introduce `SessionData` for interactive verifier flow * Added first sketches for HttpProver and Prover with Verifier state * Introduced wrapper `ServerInfo` `ServerInfo` is generated by `SessionData` and is the non-notarization version of `SessionProof` * Crate `ServerInfo` from `SessionData` in Prover<Verify> flow * Introduced another module for direct substring proofs. * WIP: Added dirty first version of prover flow... * Move `RangeCollector` and restore substring module * Tidy up tlsn-core and finish first version of prover flow for dealing with a verifier * Refactored verifier * Added `Verify` state for `Verifier` * WIP: Added first draft for verify flow... * Added more parts of verifier flow * Adapt tests to new api changes * Add some logging and improve code here and there * Added `ProofBuilder` trait and started implementing it for `SubstringsProofBuilder` * WIP: Tinkering with lifetimes... * Resolved lifetime issues * Refactor module `proof` to support another implementor of `SubstringProofBuilder` * WIP: Adding `LabelProofBuilder`... * Streamlined api * Improved decoding flow * Include lengths in `LabelProof` * Improved structure of `LabelProof` and finished `verify` * Added integration test for verify flow * Add tests for `LabelProof` * Improve test for `LabelProof::verify` * Make tlsn compile without `tlsn-formats` * Restore `tlsn-formats` from `dev` and temporarily remove from workspace * Add first batch of feedback * Add further feedback * Separated decoding from finalization * Add warning comment to `Verifier::receive` * Remove unnecessary traits * Adapt test * Repair notarize integration test * Add `decode` call to prover for verify integration test * Simplified `LabelProof` and renamed to `TranscriptProof` * Add range check to `reconstruct` * Roll back changes to `tlsn-prover/src/http` * Rename `Verify` to `Prove` * Added more feedback * Various code improvements * Remove `SessionData` * Restore naming of `TlsProof` and `SessionData` * Improve error handling * Adapt prove-verify flow to new API * Finalize VM first * Fix prover closing connection too early * Add correct server certificate and assert correct redactions * Fix imports after rebase * Fix api test in `tlsn-core` * Add feedback * Fix linting in integration test Co-authored-by: th4s <th4s@metavoid.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements functionality for an interactive verifier, who works without using commitments.
tlsn-proverandtlsn-verifierI still need to add some tests and currently debugging an error, but opened it for early feedback.