fix(tlsn-formats): prevent duplicate json array commitment (#432)

tlsnotary · Feb 12, 2024 · 82b9582 · 82b9582
1 parent a439838
commit 82b9582
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/tlsn/tlsn-formats/src/json/commit.rs b/tlsn/tlsn-formats/src/json/commit.rs
@@ -149,11 +149,13 @@ pub trait JsonCommit {
             .commit(array, direction)
             .map_err(|e| JsonCommitError::new_with_source("failed to commit array", e))?;
 
-        builder
-            .commit(&array.without_values(), direction)
-            .map_err(|e| {
-                JsonCommitError::new_with_source("failed to commit array excluding values", e)
-            })?;
+        if !array.elems.is_empty() {
+            builder
+                .commit(&array.without_values(), direction)
+                .map_err(|e| {
+                    JsonCommitError::new_with_source("failed to commit array excluding values", e)
+                })?;
+        }
 
         // TODO: Commit each value separately, but we need a strategy for handling
         // separators.