Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change webpack dev server port to avoid websocket conflict #77

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

Einstellung
Copy link
Contributor

Problem:
When running the demo prover-ts on macOS, encountered error:
"Invalid WebSocket frame: RSV1 must be clear"

Investigation:

  • Several other macOS developers have reported this issue
  • Found relevant discussions and similar cases
  • You can find detailed discussions at: websockets issues

Solution:
Based on the solutions shared in the discussions:

  • Changed webpack-dev-server port from 8080 to 3000
  • Successfully resolved the WebSocket connection issue

@heeckhau heeckhau requested a review from 0xtsukino November 27, 2024 13:37
@heeckhau
Copy link
Member

Hey @Einstellung, thanks for your PR!

I suspect there’s another process running on your computer that’s already serving HTTP data on port 8080. Your workaround of running the Prover demo on a different port is a great idea. However, port 3000 is also frequently used (e.g., for React applications). I suggest we choose a less commonly used default port instead, such as 3456. What do you think?

Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use a different port than 3000?

@Einstellung
Copy link
Contributor Author

Sorry, I previously shared the wrong link regarding my problem.

Here is the correct link

As you can see, this is not a rare issue specific to my Mac, but rather a common problem that occasionally occurs on other Mac system as well.

I've already adjusted port to 3456, and it's now working fine on my Mac.

Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@heeckhau heeckhau merged commit 2b78361 into tlsnotary:main Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants