Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupMembersScreen, ProfileSheet: wire up navigate to DM #4033

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions packages/app/features/groups/GroupMembersScreen.tsx
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
import { CommonActions } from '@react-navigation/native';
import { NativeStackScreenProps } from '@react-navigation/native-stack';
import * as store from '@tloncorp/shared/dist/store';
import { GroupMembersScreenView } from '@tloncorp/ui';
import { useCallback } from 'react';

import { useCurrentUserId } from '../../hooks/useCurrentUser';
import { useGroupContext } from '../../hooks/useGroupContext';
import { NativeStackScreenProps } from '@react-navigation/native-stack';
import { GroupSettingsStackParamList } from '../../navigation/types';


type Props = NativeStackScreenProps<
GroupSettingsStackParamList,
'GroupMembers'
>;

export function GroupMembersScreen(props: Props) {
const { groupId } = props.route.params;
export function GroupMembersScreen({ route, navigation }: Props) {
const { groupId } = route.params;
const {
groupMembers,
groupRoles,
Expand All @@ -30,9 +32,28 @@ export function GroupMembersScreen(props: Props) {

const currentUserId = useCurrentUserId();

const handleGoToDm = useCallback(
async (participants: string[]) => {
const dmChannel = await store.upsertDmChannel({
participants,
});
navigation.dispatch(
CommonActions.reset({
index: 1,
routes: [
{ name: 'ChatList' },
{ name: 'Channel', params: { channel: dmChannel } },
],
})
);
},
[navigation]
);

return (
<GroupMembersScreenView
goBack={props.navigation.goBack}
goBack={() => navigation.goBack()}
onPressGoToDm={(contactId: string) => handleGoToDm([contactId])}
members={groupMembers}
roles={groupRoles}
currentUserId={currentUserId}
Expand Down
3 changes: 3 additions & 0 deletions packages/ui/src/components/GroupMembersScreenView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export function GroupMembersScreenView({
onPressUnban,
onPressAcceptJoinRequest,
onPressRejectJoinRequest,
onPressGoToDm,
}: {
goBack: () => void;
members: db.ChatMember[];
Expand All @@ -37,6 +38,7 @@ export function GroupMembersScreenView({
onPressUnban: (contactId: string) => void;
onPressAcceptJoinRequest: (contactId: string) => void;
onPressRejectJoinRequest: (contactId: string) => void;
onPressGoToDm: (contactId: string) => void;
}) {
const { bottom } = useSafeAreaInsets();
const [selectedContact, setSelectedContact] = useState<string | null>(null);
Expand Down Expand Up @@ -207,6 +209,7 @@ export function GroupMembersScreenView({
onPressKick={() => onPressKick(selectedContact)}
onPressBan={() => onPressBan(selectedContact)}
onPressUnban={() => onPressUnban(selectedContact)}
onPressGoToDm={() => onPressGoToDm(selectedContact)}
/>
)}
{selectedContact !== null && selectedIsRequest && (
Expand Down
7 changes: 1 addition & 6 deletions packages/ui/src/components/ProfileBlock.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,7 @@ export const ProfileBlock = ({
>) => {
const contact = useContact(contactId);
return contact?.coverImage ? (
<ProfileCover
width={'100%'}
aspectRatio={1}
uri={contact.coverImage}
{...props}
>
<ProfileCover width={'100%'} uri={contact.coverImage} {...props}>
<YStack flex={1} justifyContent="flex-end">
<ProfileRow
contactId={contactId}
Expand Down
18 changes: 6 additions & 12 deletions packages/ui/src/components/ProfileSheet.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import * as db from '@tloncorp/shared/dist/db';
import * as store from '@tloncorp/shared/dist/store';
import { useCallback } from 'react';
import { Text } from 'tamagui';

import { useNavigation } from '../contexts';
import { useCurrentUserId } from '../contexts/appDataContext';
import { ActionGroup, ActionSheet, createActionGroups } from './ActionSheet';
import { Button } from './Button';
Expand Down Expand Up @@ -38,6 +36,7 @@ export function ProfileSheet({
onPressBan,
onPressUnban,
onPressKick,
onPressGoToDm,
}: {
contact?: db.Contact;
contactId: string;
Expand All @@ -49,11 +48,10 @@ export function ProfileSheet({
onPressKick?: () => void;
onPressBan?: () => void;
onPressUnban?: () => void;
onPressGoToDm?: () => void;
}) {
const currentUserId = useCurrentUserId();

const { onPressGoToDm } = useNavigation();

const handleBlock = useCallback(() => {
if (contact && contact.isBlocked) {
store.unblockUser(contactId);
Expand All @@ -63,19 +61,17 @@ export function ProfileSheet({
onOpenChange(false);
}, [contact, contactId, onOpenChange]);

const handleGoToDm = useCallback(async () => {
onPressGoToDm?.([contactId]);
onOpenChange(false);
}, [contactId, onPressGoToDm, onOpenChange]);

const isAdminnable = currentUserIsAdmin && currentUserId !== contactId;

const actions: ActionGroup[] = createActionGroups(
[
'neutral',
{
title: 'Send message',
action: () => handleGoToDm,
action: () => {
onPressGoToDm?.();
onOpenChange(false);
},
endIcon: 'ChevronRight',
},
{
Expand Down Expand Up @@ -119,8 +115,6 @@ export function ProfileSheet({
<ActionSheet
open={open}
onOpenChange={onOpenChange}
snapPointsMode="percent"
snapPoints={[90]}
>
<ActionSheet.ScrollableContent>
<ActionSheet.ContentBlock>
Expand Down