GalleryInput, NotebookInput: plumb headermode through draftInputContext #4006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving to draft to fix experimental channel switcher positioning / add buttons. |
…tents in galleries and notebooks
…all need to be aware of headerMode as well
latter-bolden
approved these changes
Oct 4, 2024
latter-bolden
deleted the
james/tlon-2914-floating-plus-button-still-needs-to-be-removed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the floating action button for Notebook and Gallery channels if the header mode isn't "next." Plumbs this through draftInputContext from the parent channel.
Also fixes the safe-area insets of channel indexes with the experimental channel switcher.
This doesn't touch the visual presentation of detail views; those components all have the right headerMode prop now but the layout is still busted. Saving for another time.