Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose: make author link to local /profile #3954

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

Fang-
Copy link
Member

@Fang- Fang- commented Sep 26, 2024

when we can. Right now, we only know this for the local ship, where it's simply /profile, assuming the public profile agent is running.

Still pending some styling adjustments from @jamesacklin.

Fang- and others added 2 commits September 25, 2024 17:16
when we can. Right now, we only know this for the local ship, where it's
simply /profile, assuming the public profile agent is running.
@jamesacklin
Copy link
Member

Changes are in.

  • Realigns author row block, inline elements; restyles link
  • Locks profile header and diary cover images to 1.6 aspect ratio
  • Fixes an issue where the border-radius on the note/post page was rounder than on the profile page

@Fang- Fang- marked this pull request as ready for review September 26, 2024 18:12
@jamesacklin jamesacklin self-requested a review September 26, 2024 18:13
Copy link
Member

@jamesacklin jamesacklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member Author

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style changes look good!

@jamesacklin jamesacklin merged commit 9e494b6 into develop Sep 26, 2024
1 check passed
@jamesacklin jamesacklin deleted the m/expose-backlink branch September 26, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants