Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

groups: make sure we leave channels in all cases of leaving a group #3948

Merged
merged 1 commit into from
Sep 25, 2024
Merged

groups: make sure we leave channels in all cases of leaving a group #3948

merged 1 commit into from
Sep 25, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Sep 23, 2024 •
edited by mikolajpp
Loading

This fixes TLON-2180 (and the other case this was happening like when you get kicked/banned)

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@arthyn arthyn requested a review from Fang- September 23, 2024 19:31
@linear Linear
Copy link

linear bot commented Sep 23, 2024

TLON-2180 groups: if the host deletes the group, make sure members leave channels

Fang-
Fang- approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tracks. Thank you!

@arthyn arthyn marked this pull request as ready for review September 25, 2024 22:51
@arthyn arthyn merged commit 4f67d63 into develop Sep 25, 2024
1 check passed
@arthyn arthyn deleted the hm/leave-channels-properly branch September 25, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fang- Fang- Fang- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthyn @Fang-