Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ops: fix incorrect kelvin version #3909

Merged
merged 1 commit into from
Sep 12, 2024
Merged

ops: fix incorrect kelvin version #3909

merged 1 commit into from
Sep 12, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Sep 12, 2024 •
edited
Loading

Fixes TLON-2652

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@arthyn arthyn requested a review from Fang- September 12, 2024 16:30
@linear Linear
Copy link

linear bot commented Sep 12, 2024

TLON-2652 desk: drop kelvin 412 support

Fang-
Fang- approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. For the record, we break compat with 412, because the import logic we added (in #3830) depends on the $egg-any:gall type in lull, which is an addition from 411.

@Fang- Fang- merged commit 7824bfa into develop Sep 12, 2024
1 check passed
@Fang- Fang- deleted the hm/correct-sys-kelvin branch September 12, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fang- Fang- Fang- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthyn @Fang-