Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channels: bad mark #3861

Merged
merged 1 commit into from
Aug 26, 2024
Merged

channels: bad mark #3861

merged 1 commit into from
Aug 26, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Aug 26, 2024

OTT, this mark should have changed when we did all our new types

@arthyn arthyn requested a review from Fang- August 26, 2024 13:39
@arthyn arthyn changed the base branch from develop to staging August 26, 2024 13:39
Fang-
Fang- approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Are you sure this mark is immutable?"
"It's a good mark sir."
Look inside the mark. Its type changed.

Good catch, thank you.

@arthyn arthyn merged commit 55228b1 into staging Aug 26, 2024
1 check passed
@arthyn arthyn deleted the hm/channels-bad-mark branch August 26, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fang- Fang- Fang- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthyn @Fang-