Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: group and channel volume settings from the chat options sheet #3825

Merged
merged 13 commits into from
Aug 15, 2024

Conversation

latter-bolden
Copy link
Member

@latter-bolden latter-bolden commented Aug 7, 2024

Moved db volume setting types over to their true values vs a native app simplified isMuted/isNoisy. Handles scry and sub updates to base. Adds a basic UI for setting group volume level which checks recursively against base (needs polish).

Still todo:

  • robust handling of recursive volume reads wherever they're accessed
  • ensure however these settings gel with top level Push Notification is baseline acceptable
    • we might be able to punt on Exceptions in the settings menu, but that probably needs to start coming into play
    • we need to think through the UX of communicating what exactly this setting does

From Pat: updated to work with the new Chat Options Sheet, also made it work for channels from that sheet. Not clear on whether we still need the other todos before merging.

Fixes TLON-2426
Fixes TLON-2175

Copy link

linear bot commented Aug 7, 2024

@patosullivan patosullivan changed the title [wip] native: group volume settings native: group and channel volume settings from the chat options sheet Aug 13, 2024
@patosullivan patosullivan marked this pull request as ready for review August 13, 2024 19:20
Copy link

linear bot commented Aug 14, 2024

@latter-bolden latter-bolden merged commit ce4e39e into develop Aug 15, 2024
1 check passed
@latter-bolden latter-bolden deleted the native-group-volume branch August 15, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants