Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activity: fix notification paths #3824

Merged
merged 4 commits into from
Aug 7, 2024
Merged

activity: fix notification paths #3824

merged 4 commits into from
Aug 7, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Aug 6, 2024

Fixes TLON-2423 by adjusting the paths we send people to, reflecting the actual routes instead of all trying to be chats. Also fixed two issues encountered when testing.

  • Creating a post and then commenting on it yourself was crashing because the source didn't exist
  • Sometimes the feed would produce bundles where the latest time didn't match any event in the bundle, which makes no sense. So I changed it to always pull the "latest" value from the list of events it sends with the bundle (instead of the event on which we built this bundle which may not be present in the bundle itself)

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Copy link

linear bot commented Aug 6, 2024

Copy link
Member

@latter-bolden latter-bolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js change makes sense

desk/app/activity.hoon Outdated Show resolved Hide resolved
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A remaining nit, but looks good otherwise.

desk/app/activity.hoon Outdated Show resolved Hide resolved
@arthyn arthyn merged commit 4857c58 into develop Aug 7, 2024
1 check passed
@arthyn arthyn deleted the hm/fix-notification-paths branch August 7, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants