Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

native: sync start fixes #3808

Merged
merged 5 commits into from
Jul 31, 2024
Merged

native: sync start fixes #3808

merged 5 commits into from
Jul 31, 2024

Conversation

latter-bolden
Copy link
Member

  • no more flashing pins, no more invalid pins model column name
  • only refetch pins when app is foregrounded
  • move foregrounded actions to only run after first initialization (i.e. subsequent app opens)
  • latest posts show up consistently (were missing after last sync changes on fresh download or logout/login)
  • fixed ordering for syncInit db writes
  • concurrent fetches for init and latestPosts while enforcing init always gets written first
  • fix straggler bug with setting joined channels
  • add sample heads data and test for syncing latest posts

Fixes TLON-2444

@linear Linear
Copy link

linear bot commented Jul 30, 2024

TLON-2444 native: ChatList drops pins, then restores them

dnbrwstr
dnbrwstr approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@dnbrwstr dnbrwstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm!

packages/shared/src/store/sync.test.ts Show resolved Hide resolved
packages/shared/src/store/sync.ts Outdated Show resolved Hide resolved
@latter-bolden @dnbrwstr
Update packages/shared/src/store/sync.ts
1b8e638 
Co-authored-by: Dan Brewster <dnbrwstr@gmail.com>
@latter-bolden latter-bolden merged commit 89cf394 into develop Jul 31, 2024
1 check passed
@latter-bolden latter-bolden deleted the lb/start-sync-fixes branch July 31, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnbrwstr dnbrwstr dnbrwstr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@latter-bolden @dnbrwstr