Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activity: dont crash feed #3773

Merged
merged 1 commit into from
Jul 19, 2024
Merged

activity: dont crash feed #3773

merged 1 commit into from
Jul 19, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Jul 19, 2024

We potentially have bad data here, so we should be careful.

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

latter-bolden
latter-bolden approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@latter-bolden latter-bolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunt value if we can't find it instead of crashing?

Makes sense to me :~)

@arthyn arthyn merged commit b03d66a into staging Jul 19, 2024
1 check passed
@arthyn arthyn deleted the hm/dont-crash-feed branch July 19, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latter-bolden latter-bolden latter-bolden approved these changes

@patosullivan patosullivan Awaiting requested review from patosullivan

@Fang- Fang- Awaiting requested review from Fang-

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthyn @latter-bolden