channels & chat: mark activity for deleted msgs as read #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever we see a deletion, mark the corresponding activity event as read. It doesn't make sense to still leave that up to the client, since they won't be rendering those messages anymore.
|
so far so good |
Instead of doing individual read marking, which is no longer supported.
Similar to the changes made to /app/channel, we want to remove activity that happened under a post, when the post itself gets deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we see a deletion, mark the corresponding activity event as read. It doesn't make sense to still leave that up to the client, since they won't be rendering those messages anymore.
Draft because we need to do this for chat also.
Closes TLON-2274.