Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activity: moving helpers to lib #3712

Merged
merged 6 commits into from
Jul 9, 2024
Merged

activity: moving helpers to lib #3712

merged 6 commits into from
Jul 9, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Jul 3, 2024

OTT, makes reading through the agent much nicer

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@arthyn arthyn marked this pull request as ready for review July 3, 2024 21:32
@arthyn arthyn requested a review from Fang- July 3, 2024 21:32
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks better indeed. How would you feel about further splitting the library up into scope-separated cores? ie having +get-parents:source:lib instead of +get-parents:lib, +get-reads:stream:lib, etc? (Though probably +src:lib and +stm:lib or w/e to avoid shadowing too hard.)

May or may not make sense for some of those to be written as doors, too, not sure how the ergonomics of that would shake out.

desk/app/activity.hoon Outdated Show resolved Hide resolved
Base automatically changed from hm/recursive-unreads to develop July 5, 2024 20:29
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed out of band, thanks for your changes. Approved!

@arthyn arthyn merged commit dd97f1a into develop Jul 9, 2024
1 check passed
@arthyn arthyn deleted the hm/activity-lib branch July 9, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants