Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activity: refine combined count for channels #3682

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Jun 27, 2024

After discussion with @latter-bolden, we decided to change how count in activity summaries gets tallied to better reflect what expect UX-wise, aka ignoring threads that don't involve us.

We refresh all summaries on load since that shouldn't take very long and likely should be done anytime the agent changes, and in this case we have to for those counts to get updated immediately.

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can debate the expectation and its implications here, but the code seems to reflect the description at least, so looks good to me.

desk/app/activity.hoon Outdated Show resolved Hide resolved
Co-authored-by: fang <git@fang.io>
@arthyn arthyn merged commit 192f520 into staging Jun 27, 2024
1 check passed
@arthyn arthyn deleted the hm/improve-combined-count branch June 27, 2024 21:02
@arthyn
Copy link
Member Author

arthyn commented Jun 27, 2024

Fixes TLON-2202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants