web: fix bug with new dm creation #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TLON-2114. We were finding the first unread that matched
ship/${theShip}and then returning that unread key as the existing DM. This got inserted into the route as/new/ship/~sampel-palnet, which putsnewin the:shipparameter place. theMessagecomponent then checks if the:shipparameter is a patp. If it's not, it assumes multidm. We then routed the user to the MultiDm component, and since they're not in a MultiDM with that ID we show the invite accept/reject page (which won't work because this isn't a mutidm and that isn't a valid multidm ID).The fix is just to return only the patp from the unread key, chopping off the
ship/portion.