Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activity: self activity should change recency #3626

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Jun 14, 2024

Fixes TLON-2088 by changing the way we give recency values in that if the "read" floor is greater than the last message, make that the recency. However to get our %read action to put a value other than the last message time, I had to change the action type slightly.

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@arthyn arthyn requested a review from Fang- June 14, 2024 22:38
Copy link

linear bot commented Jun 14, 2024

Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoon-side changes here look good, thanks for the fix!

@arthyn arthyn changed the base branch from staging to develop June 25, 2024 14:53
@arthyn arthyn merged commit b3317db into develop Jun 25, 2024
1 check passed
@arthyn arthyn deleted the hm/self-activity-should-change-recency branch June 25, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants