native: reduce space within/between chat messages, fix keyboard offset in thread view #3606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t issue in threads
dnbrwstr
approved these changes
Jun 12, 2024
| @@ -96,7 +96,9 @@ export function PostScreenView({ | |||
| <KeyboardAvoidingView | |||
| //TODO: Standardize this component, account for tab bar in a better way | |||
| behavior={Platform.OS === 'ios' ? 'padding' : 'height'} | |||
| // keyboardVerticalOffset={70} | |||
| keyboardVerticalOffset={ | |||
| Platform.OS === 'ios' ? -bottom : DEFAULT_MESSAGE_INPUT_HEIGHT | |||
There was a problem hiding this comment.
Does it make sense to extract this wrapper component and use across multiple screens? I'm guessing we have similar in other places?
There was a problem hiding this comment.
Looked for that, afaict this is the only place with this exact offset.
jamesacklin
approved these changes
Jun 12, 2024
patosullivan
force-pushed
the
po/tlon-2055-tlon-2073-fix-message-spacing-and-keyboard-offsets
branch
from
390a68a
to
e0d124e
Compare
…d the thread/postscreen view, add new shared keyboardavoidingview component
patosullivan
deleted the
po/tlon-2055-tlon-2073-fix-message-spacing-and-keyboard-offsets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TLON-2055
Fixes TLON-2073