-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activity: feed endpoints #3604
Merged
Merged
activity: feed endpoints #3604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fang-
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed out of band. Mostly just style nits. But looks like it does the right thing.
@Fang- since you're afk packing and I just implemented what you commented on going to take that as soft approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two endpoints specifically for the activity tab with pagination.
/activity/feed/init/{count}.json
gives latest items limited by count for each tab/activity/feed/{type}/{count}/{start}?.json
@ud
representing number of items you wish to receive@ud
or@da
optional parameter, will only get events before this timeall | mentions | replies
all
: any post, reply, dm, or dm reply that I was notified formentions
: any message that mentions methreads
: any replies for which I was notified forAlso updates the
add
update to include source and the stringified form of source.Fixes TLON-2036
PR Checklist