Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activity: feed endpoints #3604

Merged
merged 8 commits into from
Jun 12, 2024
Merged

activity: feed endpoints #3604

merged 8 commits into from
Jun 12, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Jun 11, 2024

This adds two endpoints specifically for the activity tab with pagination.

/activity/feed/init/{count}.json gives latest items limited by count for each tab

/activity/feed/{type}/{count}/{start}?.json

  • count: @ud representing number of items you wish to receive
  • start: @ud or @da optional parameter, will only get events before this time
  • type: all | mentions | replies
    • all: any post, reply, dm, or dm reply that I was notified for
    • mentions: any message that mentions me
    • threads: any replies for which I was notified for

Also updates the add update to include source and the stringified form of source.

Fixes TLON-2036

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Copy link

linear bot commented Jun 11, 2024

@arthyn arthyn requested a review from Fang- June 11, 2024 21:51
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed out of band. Mostly just style nits. But looks like it does the right thing.

desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/activity.hoon Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
@arthyn
Copy link
Member Author

arthyn commented Jun 12, 2024

@Fang- since you're afk packing and I just implemented what you commented on going to take that as soft approval

@arthyn arthyn merged commit def3f22 into staging Jun 12, 2024
1 check passed
@arthyn arthyn deleted the hm/feed-endpoint branch June 12, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants