mobile: channel search #3397
Merged
mobile: channel search #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re query results cause breaking errors
…selected post and posts around on search result click
…tract search results into ui package, fixtures, pull in date formatting util
…a looks right when you get to the bottom
dnbrwstr
reviewed
Apr 5, 2024
…th the author for display
dnbrwstr
requested changes
Apr 9, 2024
dnbrwstr
reviewed
Apr 9, 2024
dnbrwstr
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search.mp4
Should cover everything from the Figma spec except in message search query highlighting and stitching local/remote results together (remote only right now). The former should just be done and I'll file an issue. For the latter, we'll probably want to hold off until we have a better idea of how the local cache will work. Getting a good UX there with consistent ordering might be tricky.
Still getting sporadic errors/warnings I'm trying to track down and want to include a few tests. Added basic fixtures for a generic input, but didn't have time to take a real stab at building out a reusable Ochre lego.
Fixes LAND-1736