-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
@tleunen Hi, do you think you'll have time to check it out this week? |
Yep definitely. Will do later today. I'm free this weekend :) |
So I pushed a commit. I removed babel 6 completely and decided to set |
Shouldn't we preserve compatibility with Babel 6? We could soft-deprecate for now and deprecate completely in the next major version. I see that the tests are not passing, will look into that after work today. |
Because I moved Babel core as a direct dependency, Babel 6 is not really needed anymore. Yep I noticed it for the tests. I must have used the wrong plugin for the spread operator. Will fix it |
So we cannot really use babel 7 internally because jest is still using babel 6. So when running the tests, it fails because we go from So we can only revert everything related to babel 7 for the testing, and hope it works fine I guess :/
|
Oops 😛 If the internals are that incompatible, then there's nothing we can do. We can always drop the support in the next major release 🙂 |
Closing in favor of #78 |
This is a continuation of #75 that contains a compat change for babel-core 7.0.0-beta.3.