Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qm-migrate: add page #9367

Merged
merged 4 commits into from
Oct 28, 2022
Merged

qm-migrate: add page #9367

merged 4 commits into from
Oct 28, 2022

Conversation

dnadawa
Copy link
Contributor

@dnadawa dnadawa commented Oct 27, 2022

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 27, 2022
@kbdharun kbdharun mentioned this pull request Oct 27, 2022
Open
46 tasks
EmilyGraceSeville7cf
EmilyGraceSeville7cf suggested changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes were requested because several fixes are available and could be applied.
  • Some cases are not handled by our style guide now but should be.
  • This PR should be reviewed by qm-migrate users.
  • Thanks for a new page. 😄

pages/linux/qm-migrate.md Outdated Show resolved Hide resolved
pages/linux/qm-migrate.md Outdated Show resolved Hide resolved
pages/linux/qm-migrate.md Outdated Show resolved Hide resolved
pages/linux/qm-migrate.md Outdated Show resolved Hide resolved
pages/linux/qm-migrate.md Outdated Show resolved Hide resolved
pages/linux/qm-migrate.md Outdated Show resolved Hide resolved
pages/linux/qm-migrate.md Outdated Show resolved Hide resolved
pages/linux/qm-migrate.md Outdated Show resolved Hide resolved
pages/linux/qm-migrate.md Outdated Show resolved Hide resolved
@dnadawa
Apply suggestions from code review
3363abb 
Co-authored-by: Emily Grace Seville <emilyseville7cf@gmail.com>
@dnadawa dnadawa requested review from EmilyGraceSeville7cf and removed request for kbdharun October 27, 2022 10:07
kbdharun
kbdharun reviewed Oct 27, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page.

pages/linux/qm-migrate.md Outdated Show resolved Hide resolved
pages/linux/qm-migrate.md Outdated Show resolved Hide resolved
@dnadawa @kbdharun
Apply suggestions from code review
3abe7f0 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@kbdharun kbdharun merged commit 9cced2f into tldr-pages:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilyGraceSeville7cf EmilyGraceSeville7cf EmilyGraceSeville7cf approved these changes

@kbdharun kbdharun kbdharun approved these changes

@sbrl sbrl Awaiting requested review from sbrl

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnadawa @CLAassistant @kbdharun @EmilyGraceSeville7cf