Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autopep8: add page #5645

Merged
merged 16 commits into from
Apr 2, 2021
Merged

autopep8: add page #5645

merged 16 commits into from
Apr 2, 2021

Conversation

Waples
Copy link
Member

@Waples Waples commented Mar 30, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

bl-ue
bl-ue suggested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back @Waples! I left some comments below. Please also update the Dutch translation when you've applied the suggestions to the English one.

pages/common/autopep8.md Outdated Show resolved Hide resolved
pages/common/autopep8.md Outdated Show resolved Hide resolved
pages/common/autopep8.md Outdated Show resolved Hide resolved
pages/common/autopep8.md Outdated Show resolved Hide resolved
pages/common/autopep8.md Outdated Show resolved Hide resolved
pages/common/autopep8.md Outdated Show resolved Hide resolved
pages/common/autopep8.md Outdated Show resolved Hide resolved
pages.nl/common/autopep8.md Outdated Show resolved Hide resolved
pages.nl/common/autopep8.md Outdated Show resolved Hide resolved
pages.nl/common/autopep8.md Outdated Show resolved Hide resolved
@bl-ue bl-ue added new command Issues requesting creation of a new page. translation Translate pages from one language to another. labels Mar 30, 2021
@navarroaxel navarroaxel changed the title autopep8: init english and dutch pages autopep8: add page Mar 30, 2021
Waples and others added 12 commits March 31, 2021 12:04
@Waples @bl-ue
Update pages/common/autopep8.md
d13ded3 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples @bl-ue
Update pages/common/autopep8.md
dfc7cee 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples @bl-ue
Update pages/common/autopep8.md
b27d016 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples @bl-ue
Update pages/common/autopep8.md
b5a55c9 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples @bl-ue
Update pages/common/autopep8.md
7d1de81 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples @bl-ue
Update pages/common/autopep8.md
156097a 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples @bl-ue
Update pages/common/autopep8.md
02f2384 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples @bl-ue
Update pages/common/autopep8.md
07d996b 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples @bl-ue
Update pages.nl/common/autopep8.md
0444f2d 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples @bl-ue
Update pages.nl/common/autopep8.md
2103868 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples @bl-ue
Update pages.nl/common/autopep8.md
666681d 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples
rephrase en and nl pages
d397037
@Waples
Copy link
Member Author

Waples commented Mar 31, 2021

@bl-ue changes made.

@navarroaxel navarroaxel requested a review from bl-ue March 31, 2021 10:39
@bl-ue
Copy link
Contributor

bl-ue commented Mar 31, 2021

@Waples thank you. Here however, I updated the page description, and in d397037 I don't see an update to the nl one—can you update that real quick as well?

@Waples
Copy link
Member Author

Waples commented Apr 1, 2021

@bl-ue change made

bl-ue
bl-ue reviewed Apr 1, 2021
View reviewed changes
pages/common/autopep8.md Outdated Show resolved Hide resolved
pages.nl/common/autopep8.md Outdated Show resolved Hide resolved
Waples and others added 2 commits April 2, 2021 20:25
@Waples @bl-ue
Update pages.nl/common/autopep8.md
ee7699d 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples @bl-ue
Update pages/common/autopep8.md
f44ad1e 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples
Copy link
Member Author

Waples commented Apr 2, 2021

nittpicker :p @bl-ue changes made

bl-ue
bl-ue approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Waples!

@bl-ue bl-ue merged commit 4a7fab0 into tldr-pages:master Apr 2, 2021
@Waples Waples deleted the autopep8-en-nl branch April 2, 2021 18:32
@bl-ue bl-ue mentioned this pull request Apr 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@bl-ue bl-ue bl-ue approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page. translation Translate pages from one language to another.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Waples @bl-ue @navarroaxel