Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lvm: add page #5328

Merged
merged 8 commits into from
Mar 24, 2021
Merged

lvm: add page #5328

merged 8 commits into from
Mar 24, 2021

Conversation

aherst
Copy link
Collaborator

@aherst aherst commented Mar 1, 2021 •
edited by bl-ue
Loading

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

bl-ue
bl-ue suggested changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

pages/linux/lvm.md Outdated Show resolved Hide resolved
pages/linux/lvm.md Outdated Show resolved Hide resolved
pages/linux/lvm.md Outdated Show resolved Hide resolved
pages/linux/lvm.md Outdated Show resolved Hide resolved
@bl-ue bl-ue added the new command Issues requesting creation of a new page. label Mar 1, 2021
aherst and others added 3 commits March 1, 2021 12:21
@aherst @bl-ue
Update pages/linux/lvm.md
1f42f19 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@aherst @bl-ue
Update pages/linux/lvm.md
377707a 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@aherst @bl-ue
Update pages/linux/lvm.md
e5d1dd8 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
sbrl
sbrl reviewed Mar 8, 2021
View reviewed changes
pages/linux/lvm.md Outdated Show resolved Hide resolved
@aherst
lvm: change More information
b2ddb57 
lvm: change More information to point to man7.org.
@aherst
lvm: fix typo in description
47aa273
einverne
einverne approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks

This was referenced Mar 12, 2021
Merged
Merged
sbrl
sbrl approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but we should wait for the discussion about the more information link to be resolved before merging.

@aherst
lvm: change references to block devices
ac74edf 
Use the new notation that has been approved but not merged into the style guide.
@bl-ue bl-ue merged commit 0efcf0f into tldr-pages:master Mar 24, 2021
@aherst aherst deleted the lvm branch March 24, 2021 20:49
@bl-ue
Copy link
Contributor

bl-ue commented Mar 24, 2021

Glad to get this one over with! :)

@bl-ue bl-ue mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einverne einverne einverne approved these changes

@sbrl sbrl sbrl approved these changes

@bl-ue bl-ue bl-ue approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aherst @bl-ue @einverne @sbrl