-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Brazilian Portuguese translation for some common pages #2707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for kickstarting the Portuguese translation, @schneiderl! I added some comments inline (in Portuguese), and some small fixes (mostly missing diacritics). Please address them when you can.
Finally we have a member who can review a translation ! |
Co-Authored-By: schneiderl <casdpa@gmail.com>
Co-Authored-By: schneiderl <casdpa@gmail.com>
Co-Authored-By: schneiderl <casdpa@gmail.com>
Co-Authored-By: schneiderl <casdpa@gmail.com>
Co-Authored-By: schneiderl <casdpa@gmail.com>
Co-Authored-By: schneiderl <casdpa@gmail.com>
Co-Authored-By: schneiderl <casdpa@gmail.com>
I have commited the fixes and made the required changes. |
@schneiderl your first contribution has been merged! 🎉 As for feedback -- I'd recommend not duplicating the PR message content in the commit message, since they serve different purposes. The commit message should only describe the change itself, rather than mention plans for the future, ask for feedback, etc. Those messages are appropriate in the PR opening comment and the following discussion, though. You might want to check out @cbeams' excellent write-up on what makes a good git commit message. |
Thanks a lot for the feedback 👍 |
Translated first five pages in Portuguese.
I'm planning to translate more in the near future.
Regarding the folder name: I have created the folder based on IETF language codes (BCP 47) as it was discussed on gitter. The link for the start of the discussion can be found here.
As this is my first contribution for this repository I would like to know if there is anything missing from my side.
Thanks a lot.