Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brazilian Portuguese translation for some common pages #2707

Merged
merged 11 commits into from
Jan 14, 2019
Merged

Add Brazilian Portuguese translation for some common pages #2707

merged 11 commits into from
Jan 14, 2019

Conversation

schneiderl
Copy link
Collaborator

Translated first five pages in Portuguese.

I'm planning to translate more in the near future.

Regarding the folder name: I have created the folder based on IETF language codes (BCP 47) as it was discussed on gitter. The link for the start of the discussion can be found here.

As this is my first contribution for this repository I would like to know if there is anything missing from my side.
Thanks a lot.

@CLAassistant
Copy link

CLAassistant commented Jan 13, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kickstarting the Portuguese translation, @schneiderl! I added some comments inline (in Portuguese), and some small fixes (mostly missing diacritics). Please address them when you can.

@agnivade
Copy link
Member

Finally we have a member who can review a translation !

waldyrious and others added 9 commits January 14, 2019 09:05
Co-Authored-By: schneiderl <casdpa@gmail.com>
Co-Authored-By: schneiderl <casdpa@gmail.com>
Co-Authored-By: schneiderl <casdpa@gmail.com>
Co-Authored-By: schneiderl <casdpa@gmail.com>
Co-Authored-By: schneiderl <casdpa@gmail.com>
Co-Authored-By: schneiderl <casdpa@gmail.com>
Co-Authored-By: schneiderl <casdpa@gmail.com>
@schneiderl
Copy link
Collaborator Author

schneiderl commented Jan 14, 2019

I have commited the fixes and made the required changes.
@waldyrious can you please check them? Specially the comments on ack.md.

@owenvoke owenvoke added the translation Translate pages from one language to another. label Jan 14, 2019
@waldyrious waldyrious merged commit f353de3 into tldr-pages:master Jan 14, 2019
@waldyrious
Copy link
Member

As this is my first contribution for this repository I would like to know if there is anything missing from my side.
Thanks a lot.

@schneiderl your first contribution has been merged! 🎉

As for feedback -- I'd recommend not duplicating the PR message content in the commit message, since they serve different purposes. The commit message should only describe the change itself, rather than mention plans for the future, ask for feedback, etc. Those messages are appropriate in the PR opening comment and the following discussion, though.

You might want to check out @cbeams' excellent write-up on what makes a good git commit message.

@schneiderl
Copy link
Collaborator Author

Thanks a lot for the feedback 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants