Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpremote: add page #15573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mpremote: add page #15573

wants to merge 1 commit into from
+24 −0

Conversation

Coedice
Copy link
Contributor

@Coedice Coedice commented Jan 21, 2025

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 1.24.1

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Jan 21, 2025
gutjuri
gutjuri reviewed Jan 23, 2025
View reviewed changes
pages/common/mpremote.md Outdated

- Run a script on a connected device:

`mpremote run {{/path/to/script.py}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be an absolute path? It it a remote path or a local path?

Copy link
Contributor Author

@Coedice Coedice Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Fixed and pushed

pages/common/mpremote.md Outdated

- Mount a local directory to the device:

`mpremote mount {{/path/to/directory}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be an absolute path? Otherwise, we should choose to put a relative path into the tldr page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gutjuri gutjuri gutjuri left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Coedice @gutjuri