-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pulumi-config: add page #14820
pulumi-config: add page #14820
Conversation
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
Co-authored-by: Wiktor Perskawiec <git@spageektti.cc>
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thanks for your contribution.
Co-authored-by: Wiktor Perskawiec <git@spageektti.cc>
Co-authored-by: Wiktor Perskawiec <git@spageektti.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Denis-Kuso It's been a while since there was activity here so I merged a couple of suggestions that were left for you. If you feel strongly about your original edits let us know. Otherwise, I think this is good to merge :)
I was sure those changes were accepted as a batch of suggested changes. Regardless, all is well. :) |
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after the suggestions are applied.
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
Closes & reopened bc of CLA test |
common
,linux
,osx
,windows
,sunos
,android
, etc.