Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piper: add Spanish translation #13257

Merged
merged 3 commits into from
Jul 30, 2024
Merged

piper: add Spanish translation #13257

merged 3 commits into from
Jul 30, 2024

Conversation

kant
Copy link
Member

@kant kant commented Jul 11, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@kant kant added the translation Translate pages from one language to another. label Jul 11, 2024
@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.es/common/piper.md is outdated, based on the command contents itself.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.


- Transmite la salida al reproductor multimedia mpv:

`echo {{'Hola mundo'}} | piper -m {{en_GB-northern_english_male-medium.onnx}} --output-raw -f - | mpv -`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`echo {{'Hola mundo'}} | piper -m {{en_GB-northern_english_male-medium.onnx}} --output-raw -f - | mpv -`
`echo {{'Hola mundo'}} | piper -m {{en_GB-northern_english_male-medium.onnx}} --output-raw -f - | mpv -`

You should change the voice model from english or do not translate the text. Maybe the page author can help.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line updated

@sebastiaanspeck sebastiaanspeck added the review needed Prioritized PRs marked for reviews from maintainers. label Jul 13, 2024
@blueskyson blueskyson merged commit 9250ebe into main Jul 30, 2024
7 checks passed
@blueskyson blueskyson deleted the kant-patch-4 branch July 30, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review needed Prioritized PRs marked for reviews from maintainers. translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants