Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill: remove the --table long option #13241

Merged
merged 3 commits into from
Aug 10, 2024
Merged

kill: remove the --table long option #13241

merged 3 commits into from
Aug 10, 2024

Conversation

Managor
Copy link
Collaborator

@Managor Managor commented Jul 7, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):
    2.40.2

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Jul 7, 2024
@Managor
Copy link
Collaborator Author

Managor commented Jul 7, 2024

Not sure what the manual page is on about, --table option does not work.

pages/linux/kill.md Outdated Show resolved Hide resolved
@acuteenvy
Copy link
Member

Not sure what the manual page is on about, --table option does not work.

It works for me.

$ kill --table
1 HUP      2 INT      3 QUIT     4 ILL      5 TRAP     6 ABRT     6 IOT      7 BUS      8 FPE      9 KILL    10 USR1    11 SEGV    12 USR2    13 PIPE    14 ALRM    15 TERM    16 STKFLT  17 CHLD
17 CLD     18 CONT    19 STOP    20 TSTP    21 TTIN    22 TTOU    23 URG     24 XCPU    25 XFSZ    26 VTALRM  27 PROF    28 WINCH   29 IO      29 POLL    30 PWR     31 SYS     34 RTMIN   64 RTMAX
$ kill -L
<same output as above>

I'm on the same version as you (2.40.2). What does kill --table print on your system?

@Managor
Copy link
Collaborator Author

Managor commented Jul 7, 2024

kill --table
-bash: kill: -table: invalid signal specification

Co-authored-by: spageektti <git@spageektti.cc>
@acuteenvy
Copy link
Member

acuteenvy commented Jul 7, 2024

This page and man kill document kill from util-linux, but you seem to be using the bash builtin kill.
Try enable -n kill && kill --table.

I guess we have to edit the page to somehow mention it.

@Managor
Copy link
Collaborator Author

Managor commented Jul 8, 2024

That seems to indeed be the case. enable -n kill && kill --table works as expected and prints the signals.

@cyqsimon
Copy link
Collaborator

cyqsimon commented Jul 9, 2024

This page and man kill document kill from util-linux, but you seem to be using the bash builtin kill. Try enable -n kill && kill --table.

I guess we have to edit the page to somehow mention it.

Very interesting! I did not know that.

Running kill --help (the shell builtin) gives the following justification, which does make sense.

Kill is a shell builtin for two reasons: it allows job IDs to be used
instead of process IDs, and allows processes to be killed if the limit
on processes that you can create is reached.

@sebastiaanspeck sebastiaanspeck added the decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. label Jul 13, 2024
@sebastiaanspeck
Copy link
Member

A friendly reminder that this PR is still open. Waiting for a decision or a commit

@Managor
Copy link
Collaborator Author

Managor commented Aug 10, 2024

I'm thinking that we should pass this PR because the result would be more universal and then create an issue to either think about it later or forget about it.
@acuteenvy Can you create an issue about this?

pages/linux/kill.md Outdated Show resolved Hide resolved
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
@acuteenvy acuteenvy changed the title kill: update page kill: remove the --table long option Aug 10, 2024
@acuteenvy acuteenvy merged commit 5e4eb6b into tldr-pages:main Aug 10, 2024
4 checks passed
sebastiaanspeck added a commit that referenced this pull request Aug 13, 2024
spageektti pushed a commit that referenced this pull request Aug 13, 2024
@Managor Managor deleted the kill branch September 7, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants