Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qm-disk-resize: add page; qm-resize: add alias page #10496

Merged
merged 10 commits into from
Jul 14, 2023

Conversation

BabaYaga1221
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jul 13, 2023
@acuteenvy acuteenvy changed the title Update qm-resize page qm-resize: add page Jul 13, 2023
@kbdharun kbdharun changed the title qm-resize: add page qm-resize, qm-suspend: add page Jul 14, 2023
@kbdharun kbdharun changed the title qm-resize, qm-suspend: add page qm-resize: add page Jul 14, 2023
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

I would suggest merging this branch with the main as the qm-suspend page was merged a couple of days ago. In future, when creating PRs I would suggest creating a fresh branch with the head branch as tldr-pages/tldr:main. An alternative is enabling allow maintainers to write to this branch in the right side of page so that we could do the same for you.

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just now checked the man page again, I think this page can be made into an alias page and the other commands be moved to the qm-disk-resize page.

@kbdharun kbdharun mentioned this pull request Jul 14, 2023
46 tasks
pages/linux/qm-disk-resize.md Outdated Show resolved Hide resolved
pages/linux/qm-resize.md Outdated Show resolved Hide resolved
@kbdharun kbdharun changed the title qm-resize: add page qm-disk-resize: add page; qm-resize: add alias page Jul 14, 2023
@BabaYaga1221
Copy link
Contributor Author

Thanks @kbdharun , can you merge this work?

@kbdharun
Copy link
Member

can you merge this work?

This PR needs one more approval review from other maintainers to be merged.

pages/linux/qm-disk-resize.md Outdated Show resolved Hide resolved
pages/linux/qm-disk-resize.md Outdated Show resolved Hide resolved
@BabaYaga1221 BabaYaga1221 requested a review from acuteenvy July 14, 2023 17:06
@acuteenvy acuteenvy merged commit f55f1a6 into tldr-pages:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants