[M2a] Storage align #422
Merged
[M2a] Storage align #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
requested review from
comaniac,
junrushao,
merrymercy,
tqchen,
were,
yzhliu and
ZihengJiang
as code owners
vinx13
force-pushed
the
staging_storage_align
branch
from
aa8bfa0
to
8f431f0
Compare
|
cc @Hzfengsy please help to shepherd this PR |
MasterJH5574
reviewed
Aug 2, 2021
python/tvm/tir/schedule/schedule.py
Outdated
Comment on lines
511
to
513
|
|
||
| ########## Schedule: loop binding/annotation ########## | ||
| def storage_align(self, block: BlockRV, buffer_index: int, axis: int, factor: int, |
There was a problem hiding this comment.
It's a bit strange to put storage_align() in the "loop binding/annotation" category, as the primitive doesn't play with any loop. My proposal is to add a new category named "buffer transformation", which can contain primitives like storage_align(), set_scope(), etc.
Hzfengsy
requested changes
Aug 4, 2021
python/tvm/tir/schedule/schedule.py
Outdated
Comment on lines
511
to
513
|
|
||
| ########## Schedule: loop binding/annotation ########## | ||
| def storage_align(self, block: BlockRV, buffer_index: int, axis: int, factor: int, |
MasterJH5574
reviewed
Aug 4, 2021
MasterJH5574
reviewed
Aug 4, 2021
vinx13
force-pushed
the
staging_storage_align
branch
2 times, most recently
from
327627f
to
2912342
Compare
MasterJH5574
reviewed
Aug 6, 2021
MasterJH5574
reviewed
Aug 6, 2021
Hzfengsy
approved these changes
Aug 6, 2021
|
Please address the comments and send the PR to mainline. I'd love to do another round of review there |
MasterJH5574
reviewed
Aug 8, 2021
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
vinx13
force-pushed
the
staging_storage_align
branch
from
6cdd3ab
to
730ecab
Compare
vinx13
force-pushed
the
staging_storage_align
branch
from
730ecab
to
1bf6f27
Compare
|
Comments have been addressed, please review again |
|
Please send this PR to mainline for a second review :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.