Skip to content

Commit

Permalink
fix(Page): updated onPageResize prop to undefined default (patternfly…
Browse files Browse the repository at this point in the history
  • Loading branch information
andyyvo authored and Titani committed Oct 13, 2022
1 parent f6a0b42 commit 133089f
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 14 deletions.
1 change: 0 additions & 1 deletion packages/react-core/src/components/Page/Page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ export class Page extends React.Component<PageProps, PageState> {
isManagedSidebar: false,
isBreadcrumbWidthLimited: false,
defaultManagedSidebarIsOpen: true,
onPageResize: (): void => null,
mainTabIndex: -1,
isNotificationDrawerExpanded: false,
onNotificationDrawerExpand: () => null,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`Page Check dark page against snapshot 1`] = `
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -65,7 +65,7 @@ exports[`Page Check page horizontal layout example against snapshot 1`] = `
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -129,7 +129,7 @@ exports[`Page Check page to verify breadcrumb is created - PageBreadcrumb syntax
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -296,7 +296,7 @@ exports[`Page Check page to verify breadcrumb is created 1`] = `
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -463,7 +463,7 @@ exports[`Page Check page to verify grouped nav and breadcrumb - new components s
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -749,7 +749,7 @@ exports[`Page Check page to verify grouped nav and breadcrumb - old / props synt
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -1040,7 +1040,7 @@ exports[`Page Check page to verify nav is created - PageNavigation syntax 1`] =
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -1219,7 +1219,7 @@ exports[`Page Check page to verify skip to content points to main content region
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
data-testid="page-test-id"
id="PageId"
>
Expand Down Expand Up @@ -1394,7 +1394,7 @@ exports[`Page Check page vertical layout example against snapshot 1`] = `
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -1455,7 +1455,7 @@ exports[`Page Sticky bottom breadcrumb on all height breakpoints - PageBreadcrum
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -1622,7 +1622,7 @@ exports[`Page Verify sticky bottom breadcrumb on all height breakpoints 1`] = `
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -1789,7 +1789,7 @@ exports[`Page Verify sticky top breadcrumb on all height breakpoints - PageBread
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -1956,7 +1956,7 @@ exports[`Page Verify sticky top breadcrumb on all height breakpoints 1`] = `
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down

0 comments on commit 133089f

Please sign in to comment.