Skip to content

feat(Modal next): Introduce a next composable Modal (#9852) #72

feat(Modal next): Introduce a next composable Modal (#9852)

feat(Modal next): Introduce a next composable Modal (#9852) #72

Triggered via push January 5, 2024 17:03
Status Failure
Total duration 12m 39s
Artifacts 1

release.yml

on: push
Matrix: test_integration
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 20 warnings
lint: packages/react-core/src/next/components/Modal/__tests__/Modal.test.tsx#L52
Replace `"modal-div"` with `'modal-div'`
lint: packages/react-core/src/next/components/Modal/__tests__/Modal.test.tsx#L78
Replace `<Modal·isOpen·disableFocusTrap>No·close·button·</Modal>` with `⏎······<Modal·isOpen·disableFocusTrap>⏎········No·close·button{'·'}⏎······</Modal>⏎····`
lint: packages/react-core/src/next/components/Modal/__tests__/ModalBoxHeader.test.tsx#L19
Replace `⏎····<ModalHeader>⏎······{header}⏎····</ModalHeader>⏎··` with `<ModalHeader>{header}</ModalHeader>`
lint: packages/react-core/src/next/components/Modal/__tests__/ModalBoxTitle.test.tsx#L8
Replace `⏎····<ModalBoxTitle·title="Test·Modal·Box·warning"·id="boxId"·titleIconVariant="warning"/>⏎··` with `<ModalBoxTitle·title="Test·Modal·Box·warning"·id="boxId"·titleIconVariant="warning"·/>`
lint: packages/react-core/src/next/components/Modal/__tests__/ModalBoxTitle.test.tsx#L15
Replace `⏎····<ModalBoxTitle·title="Test·Modal·Box·info"·id="boxId"·titleIconVariant="info"·/>⏎··` with `<ModalBoxTitle·title="Test·Modal·Box·info"·id="boxId"·titleIconVariant="info"·/>`
lint: packages/react-core/src/next/components/Modal/__tests__/ModalBoxTitle.test.tsx#L22
Replace `⏎····<ModalBoxTitle·title="Test·Modal·Box·danger"·id="boxId"·titleIconVariant="danger"·/>⏎··` with `<ModalBoxTitle·title="Test·Modal·Box·danger"·id="boxId"·titleIconVariant="danger"·/>`
lint: packages/react-core/src/next/components/Modal/__tests__/ModalBoxTitle.test.tsx#L29
Replace `⏎····<ModalBoxTitle·title="Test·Modal·Box·warning"·id="boxId"·titleIconVariant="custom"·/>⏎··` with `<ModalBoxTitle·title="Test·Modal·Box·warning"·id="boxId"·titleIconVariant="custom"·/>`
lint: packages/react-core/src/next/components/Modal/__tests__/ModalBoxTitle.test.tsx#L36
Replace `⏎····<ModalBoxTitle·title="Test·Modal·Box·success"·id="boxId"·titleIconVariant="success"/>⏎··` with `<ModalBoxTitle·title="Test·Modal·Box·success"·id="boxId"·titleIconVariant="success"·/>`
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
demo_app
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, actions/cache@v2, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint: packages/react-core/src/components/BackToTop/BackToTop.tsx#L36
The 'toggleVisible' function makes the dependencies of useEffect Hook (at line 74) change on every render. Move it inside the useEffect callback. Alternatively, wrap the definition of 'toggleVisible' in its own useCallback() Hook
lint: packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx#L180
React Hook useEffect has a missing dependency: 'focusedDate'. Either include it or remove the dependency array
lint: packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx#L187
React Hook useEffect has a missing dependency: 'shouldFocus'. Either include it or remove the dependency array
lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L134
React Hook React.useMemo has a missing dependency: 'placeholder.length'. Either include it or remove the dependency array
lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L145
React Hook React.useEffect has a missing dependency: 'dateParse'. Either include it or remove the dependency array. If 'dateParse' changes too often, find the parent component that defines it and wrap that definition in useCallback
lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L156
React Hook React.useEffect has missing dependencies: 'dateIsRequired', 'dateParse', 'emptyDateText', 'errorText', 'pristine', 'setError', and 'textInputFocused'. Either include them or remove the dependency array. If 'dateParse' changes too often, find the parent component that defines it and wrap that definition in useCallback
lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L222
React Hook useImperativeHandle has an unnecessary dependency: 'selectOpen'. Either exclude it or remove the dependency array
lint: packages/react-core/src/components/Drawer/DrawerPanelContent.tsx#L245
Assignments to the 'setInitialVals' variable from inside React Hook React.useCallback will be lost after each render. To preserve the value over time, store it in a useRef Hook and keep the mutable value in the '.current' property. Otherwise, you can move this variable directly inside React.useCallback
lint: packages/react-core/src/components/Drawer/DrawerPanelContent.tsx#L261
React Hook React.useCallback has missing dependencies: 'handleControlMove' and 'position'. Either include them or remove the dependency array
lint: packages/react-core/src/components/Drawer/DrawerPanelContent.tsx#L262
React Hook React.useCallback has missing dependencies: 'callbackTouchEnd', 'callbackTouchMove', 'currWidth', 'id', and 'onResize'. Either include them or remove the dependency array. If 'onResize' changes too often, find the parent component that defines it and wrap that definition in useCallback
test_jest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
test_integration (3, 5)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, actions/cache@v2, actions/download-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
test_integration (1, 5)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, actions/cache@v2, actions/download-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
test_integration (2, 5)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, actions/cache@v2, actions/download-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
test_integration (4, 5)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, actions/cache@v2, actions/download-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
test_integration (0, 5)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, actions/cache@v2, actions/download-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
docs
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Artifacts

Produced during runtime
Name Size
demo-app Expired
3.38 MB