-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform dependency update, simplify development with Docker (#48) #49
Perform dependency update, simplify development with Docker (#48) #49
Conversation
requirements.txt
Outdated
ntlm-auth==1.5.0 | ||
python-dateutil==2.8.2 | ||
requests==2.26.0 | ||
requests-toolbelt==0.9.1 | ||
requests_ntlm==1.1.0 | ||
six==1.16.0 | ||
url-normalize==1.4.3 | ||
ujson==4.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instructions for installing arcgis
with minimum dependencies seem to have changed. They want you to specify dependencies yourself, including ntlm-auth
, requests
(which we use already), requests-toolbelt
, requests_ntlm
, six
, and ujson
. Some of these dependencies seem to be out of date, especially the ntlm
-related ones. This seems to work though.
See https://developers.arcgis.com/python/guide/install-and-set-up/#Install-with-minimum-dependencies for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me. I ran docker-compose runs successfully with Canvas test environment. Note updates are needed for some the test environment values.
@zqian, what do you mean by "test environment values"? Do you mean the sample configuration file or something in Dropbox or OpenShift? |
I'm gonna merge this, we can do some additional testing with the OpenShift deployment before we release. |
This PR updates the Python base image to 3.8 (and uses
-slim
to keep the image small), updates thepip
dependencies, pinsarcgis
in the separateDockerfile
step, and then adds more Docker artifacts, including a.dockerignore
and adocker-compose.yml
. The PR aims to resolve #48.