Web Theme: Refine Selectors (Fixes #132) #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decent amount of selector changes, partially to avoid theming Big Picture, partially a general cleanup.
Big Picture
Steam provides a useful node ID for avoiding this:
But as it isn't a top level node, tooltips and other hover elements that like to get injected as a direct child of
body
will bypass this. For these we have to resort to using a:not()
selector on the body class itself.Cleanup
Did a bit of cleanup to avoid straight up using:
type selectors. Now most selectors include the tag of the element they're targeting:
Which should at least be a slightly less blatant abuse of wildcard selectors. Moving forward we should avoid tagless selectors when possible.
There are a couple stragglers left where I couldn't easily trigger the corresponding elements to show, like with
cloudconflict_
.Dialog selectors that were too general have been constrained to
.ModalDialogPopup
: