-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta: Interface Changes #144
Comments
Just installed v38 and yeah....it's rough. Seems deleting everything in .steam/skins doesn't revert all changes, either. |
@Eschguy This skin patches a few css files outside of the Use one of the following methods:
|
Opened a PR to add uninstall info to the readme. I also have an initial beta branch here. Unfortunately this comes at a bad time, as I'm not going to have much time to polish this further in the immediate future. So there's the heads up if anyone wants to fix this up more. You can find information about inspecting Steam's classes here If you're still interested in using the beta, you can tide yourself over via: git clone https://github.com/Foldex/Adwaita-for-Steam.git -b beta
cd Adwaita-for-Steam
./install.py The rest is still going to take some work, but at least this is much less in your face broken. We still have a loss of customization since we no longer have control over the underlying layout of the headerbars like with VGUI. This means stuff like adding new buttons/links is pretty much out of the question, since to my knowledge there's no easy way to patch the underlying html. Being stuck with css, we can only style elements, not add them. On the plus side, the elimination of VGUI does also effectively clean up some of the longer standing VGUI issues: |
Had time to update the beta branch a little: Forward/Back Arrows had to be hidden since I couldn't find a good place for them. Still needs work:
|
@Foldex It looks perfect, good job! |
Unfortunately it's a case of having to resort to hackery to get it like this. The headerbar isn't actually a single row, it's two different rows being overlayed on top of each other. The actual layout (which we no longer control) looks something like this: So the center and sides aren't really "aware" of each other's personal space. I could maybe do some squeezing of elements at smaller window sizes (the profile button being a good candidate), but technically there is nothing preventing overlap if it does occur. The alternative is to keep the dual row layout which would look awful and really doesn't fit adwaita at all. For similar lack of layout control reasons, I can't just shove the left menu into a adwaita-style hamburger menu like we used to. I could make it expand horizontally on hover though I guess. |
it indeed does not fit the general adwaita style, but if you have to go with that, you can probably make it look like Epiphany or Nautilus tabs, could at least be made into a option as for the back and forwards buttons the far left would make sense if you follow Nautilus design, but i still think it would look weird |
screen.webm
Just gonna put any further updates here: #150 |
Latest Beta dropped, bringing with it a number of changes.
Unfortunately has some loss of functionality associated on our end, seems Valve likes making it hard on skin makers.
Regardless, seems like supporting this will involve some significant changes.
webkit.css
from one is no longer an option. This breaks anything still using that (Login, Friends, etc), and those will have to be moved into client patches.webkit.css
will no longer be injected there.pagedsettings_PagedSettings
dialog, so it at least inherits that existing styling.The text was updated successfully, but these errors were encountered: