Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeScript 7 compatibility #73

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

grey280
Copy link

@grey280 grey280 commented Sep 23, 2020

Updating the dependencies and references. Does require bumping the ES version, but I went with the minimum version to allow compatibility with NS7 and Angular 10.

@lochstar
Copy link

lochstar commented Oct 8, 2020

@tjvantoll can we get this merged?

src/tsconfig.json Outdated Show resolved Hide resolved
src/package.json Outdated Show resolved Hide resolved
@@ -1,6 +1,6 @@
{
"name": "nativescript-iqkeyboardmanager",
"version": "1.5.1",
"version": "1.5.2",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major compatibility change means this will no longer be compatible with NS6 projects, ideally this means that this should be bumped to 2.0.0.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, but I'll leave that decision up to @tjvantoll (or you, if you wind up publishing this version instead)

@Codex-
Copy link

Codex- commented Oct 12, 2020

It appears that there was an updated version published already: https://www.npmjs.com/package/@nativescript/iqkeyboardmanager

There seems to be a weird divide between this repo and that publication though, so probably still worth fixing up and merging these

@brysem
Copy link

brysem commented Oct 21, 2020

It appears that there was an updated version published already: https://www.npmjs.com/package/@nativescript/iqkeyboardmanager

There seems to be a weird divide between this repo and that publication though, so probably still worth fixing up and merging these

It's quite confusing really. It appears to be moved here. Would be nice to see that in the readme. Looking at this repository made me believe that this project was abandoned without any additional information.

https://github.com/NativeScript/plugins/tree/master/packages/iqkeyboardmanager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants