WIP - add e2e keyboard navigation util functions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (Issue WordPress#12392) using bug resolved in WordPress#11773 as the basis for the steps
…ThroughBlockMoverControl` and `tabThroughBlockToolbar` to the parent scope. Using pressKeyWithModifier within navigateToContentEditorTop.
…'s toolbar buttons
…abThroughBlockToolbar to e2e-test-utils
Merged
5 tasks
|
This is cool, I like where it is heading 💯 |
|
Any plans to offer it as a patch to Gutenberg? 😃 |
|
Sorry, just started a new job a few weeks back, and have been getting adjusted to that situation. I'll hopefully have it ready soon! |
…5-add-e2e-keyboard-navigation-util-functions # Conflicts: # packages/e2e-tests/specs/keyboard-navigable-blocks.test.js
tjnicolaides
changed the base branch from
add/12392-add-e2e-test-keyboard-navigation-through-blocks
to
master
…olbar, tab-through-block-mover-control, keyboard-navigable-blocks-test. Add some detail to JSDocs
…-functions # Conflicts: # packages/e2e-tests/specs/keyboard-navigable-blocks.test.js
…-functions # Conflicts: # packages/e2e-tests/specs/keyboard-navigable-blocks.test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thinking through some refactoring challenges related to @gziolo's suggestion before continuing on to create a block-agnostic test .
Currently thinking about that block-agnostic test living in
keyboard-navigable-blocks.test.jsand the paragraph order tests to check for regression of WordPress#11773 should live in a different file