Skip to content

Commit

Permalink
🤖 Merge PR DefinitelyTyped#61920 update(zingchart): add tree-related …
Browse files Browse the repository at this point in the history
…options properties by @jeanettephung

* Add types for zingchart

* Adds content header to zingchart

* Fixes typedef extends for lint

* Fixes version, import, and empty jsdoc comments

* Removes last empty jsdoc comment

* Allows values and series types to be arrays

* Fixes values type

* ZingChart type updates

* Added d.ts file for zingchart/es6 and applied fixes

* Move definitions in es6/index and reference in index.d.ts

* Update test to include added attributes

* Add .d.ts for ZingChart NodeJS build

* Apply fixes after running "npm test"

* Add additional test using NodeJS d.ts

* Included new files into  in tsconfig

* Fix JSON format for tsconfig

* Rewrite .d.ts for NodeJS build and combine tests into one file

* Only list one d.ts in tsconfig and reference NodeJS d.ts in test

* Provide default exports

* Update to include default exports

* Update test to try default import

* Allow default export and fix exports for each version (originally assumed exports were the same)

* use nodejs version in test because required to use file

* Fix whitespace error in test

* Update test to include testing default import

* Fixed zingchart/index.dts based on reviewers notes

* Update tslint.json to remove rules no longer needed

* Corrections to TDF relating to plot and legend

* Asterisk fix

* update(zingchart): Add def for plot.tooltip.text

* create(zinggrid): add new typings

* update(zingchart): Add missing types for plot and graphset

* Remove redundant 'undefined' value and fix trailing whitespace

* Updated definition author

* Added camel-case version of attributes

* refactor definitions

* Update exec arg to be optional

* Add missing properties: series.id
series.type
graphset.utc
graphset.plot.selectedState.lineWidth
graphset.plot.tooltip.textAlign
graphset.plot.valueBox.fontSize (doesn't accept numbers, only string)
graphset.maxTrackers
graphset.legend.marker.borderRadius
graphset.scaleX.maxItems
graphset.scaleY.zooming

* Fix alignment issues

* Update/fix properties:
- *.lineWidth
- *.borderWidth
- graphset.plot.dataAppendSelection
- graphset.plot.dataIgnoreSelection
- graphset.plot.selectionMode
- graphset.scaleX.thousandsSeparator
- graphset.scaleX.zooming
- graphset.plot.highlight
- graphset.timeZone

* Add missing attributes:
- graphset.legend.marker.borderRadius (type)
- graphset.plot.highlight
- graphset.zoomSnap
- graphset.selectionTool

* Added tests for previous commit

* update(zingchart): add behavior.text and behavior.customFunction, and updated graphset.labels

* Add definitions for palette (theme)

* update(zingchart): Add missing transform definitions

* remove consecutive blank lines

* Add definitions for scaleX (minValue, step) and scaleY (step)

* Updated the typing for scaleX/Y.step

* mend

* Update test

* Add legendMarker.borderRadius and related attributes

* Added legendMarker.lineStyle

* update(zingchart): update typings for offsetEnd/Start

* update(zingchart): add series.zIndex

* update(zingchart): add typings for tooltip.htmlMode and valueBox.Rules

* update(zingchart): fix array typings

* updated lslint and array typings

* fix tslint file

* revert tslint.json changes

* update(zingchart) - add preview.visible, tooltip.rules, scaleX.itemsOverlap

* Added graphset.values, plot.rules.*, tooltip.rules.*

* update(zingchart): add tree-related options properties

Co-authored-by: Mike Schultz <mschultz@zingsoft.com>
Co-authored-by: dannyjuergens <djuergens@zingsoft.com>
Co-authored-by: jphung <jphung@zingsoft.com>
  • Loading branch information
4 people authored Aug 24, 2022
1 parent 8c7056c commit 4ff2a27
Show file tree
Hide file tree
Showing 3 changed files with 1,578 additions and 554 deletions.
Loading

0 comments on commit 4ff2a27

Please sign in to comment.