Fixes intelsdi-x#1113: removes fixed max-failure value from task crea…

…tion

cmd/snapctl/flags.go

@@ -19,10 +19,13 @@ limitations under the License.
 
 package main
 
-import "github.com/codegangsta/cli"
+import (
+	"github.com/codegangsta/cli"
+	"github.com/intelsdi-x/snap/mgmt/rest"
+)
 
 const (
-	DefaultMaxFailures = 10
+	DefaultMaxFailures = rest.DefaultMaxFailures
 )
 
 var (

core/task.go

@@ -197,7 +197,12 @@ func CreateTaskFromContent(body io.ReadCloser,
 	if tr.Name != "" {
 		opts = append(opts, SetTaskName(tr.Name))
 	}
-	opts = append(opts, OptionStopOnFailure(10))
+
+	// if a MaxFailures value is included as part of the task creation request
+	if tr.MaxFailures > 0 {
+		// then set the appropriate value in the opts
+		opts = append(opts, OptionStopOnFailure(tr.MaxFailures))
+	}
 
 	if mode == nil {
 		mode = &tr.Start

scheduler/task.go

@@ -34,15 +34,16 @@ import (
 	"github.com/intelsdi-x/snap/core"
 	"github.com/intelsdi-x/snap/core/scheduler_event"
 	"github.com/intelsdi-x/snap/grpc/controlproxy"
+	"github.com/intelsdi-x/snap/mgmt/rest"
 	"github.com/intelsdi-x/snap/pkg/schedule"
 	"github.com/intelsdi-x/snap/scheduler/wmap"
 )
 
 const (
 	// DefaultDeadlineDuration - The default timeout is 5 second
 	DefaultDeadlineDuration = time.Second * 5
-	// DefaultStopOnFailure - The default stopping a failure is after three tries
-	DefaultStopOnFailure = 3
+	// DefaultStopOnFailure - The default stopping a failure is after ten tries
+	DefaultStopOnFailure = rest.DefaultMaxFailures
 )
 
 var (