Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix being able to see submissions after course is archived #53

Merged
merged 3 commits into from
Jul 2, 2024
Merged

fix being able to see submissions after course is archived #53

merged 3 commits into from
Jul 2, 2024

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented Jun 13, 2024 •
edited
Loading

I should add a test for this shouldn't I 🤔 (EDIT: done)

@JasonGrace2282 JasonGrace2282 self-assigned this Jun 13, 2024
@JasonGrace2282 JasonGrace2282 requested a review from a team as a code owner June 13, 2024 04:57
@JasonGrace2282 JasonGrace2282 marked this pull request as draft June 13, 2024 05:06
@JasonGrace2282 JasonGrace2282 marked this pull request as ready for review June 13, 2024 15:45
@JasonGrace2282 JasonGrace2282 marked this pull request as draft June 15, 2024 18:11
@JasonGrace2282 JasonGrace2282 marked this pull request as ready for review June 15, 2024 18:19
krishnans2006
krishnans2006 requested changes Jun 29, 2024
View reviewed changes
Copy link
Member

@krishnans2006 krishnans2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but here's a quick change that you should consider adding to this PR:

krishnans2006
krishnans2006 approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@krishnans2006 krishnans2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

In the future, we might want to consider simplifying the somewhat hard-to-read query statements in QuerySets, but I don't know how we would go about that at the moment.

@krishnans2006 krishnans2006 force-pushed the master branch 2 times, most recently from 305ca99 to ad43913 Compare June 30, 2024 19:07
@krishnans2006 krishnans2006 merged commit 2981967 into tjcsl:master Jul 2, 2024
3 checks passed
@JasonGrace2282 JasonGrace2282 deleted the fix-submission branch July 2, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnans2006 krishnans2006 krishnans2006 approved these changes

Assignees

@JasonGrace2282 JasonGrace2282

Labels
app/submissions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonGrace2282 @krishnans2006