Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Ignore LF/CRLF differences #101

Closed
2 tasks done
C0ZEN opened this issue Nov 5, 2021 · 5 comments · Fixed by #102 or #116
Closed
2 tasks done

[Feature] Ignore LF/CRLF differences #101

C0ZEN opened this issue Nov 5, 2021 · 5 comments · Fixed by #102 or #116
Labels
enhancement New feature or request

Comments

@C0ZEN
Copy link

C0ZEN commented Nov 5, 2021

Is this feature missing in the latest version?

  • I'm using the latest release

Is your feature request related to a problem? Please describe.

I think that I have an issue because locally, I am pushing CLRF files and on my CI, I recreate them and perform the diff (on a folder).
This action is telling me that there is a difference and a warning about the EOL is visible (seems logical since the CI is using Linux).

Describe the solution you'd like?

Add a new input to ignore the EOL (default is false to not create a breaking change).

Describe alternatives you've considered?

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@C0ZEN C0ZEN added the enhancement New feature or request label Nov 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

Thanks for reporting this issue.

jackton1 added a commit that referenced this issue Nov 6, 2021
jackton1 added a commit that referenced this issue Nov 6, 2021
* Disable Automatic CRLF for windows

Fixes: #101

* Update test.yml

* Update entrypoint.sh

* Update test.yml
@C0ZEN
Copy link
Author

C0ZEN commented Nov 7, 2021

@jackton1 thank you for taking care of this.
I checked if something has changed with the latest version.
However, I still have the same issue.

If you need more insights, here is the failing step https://github.com/Sonia-corporation/stale/runs/4130318260?check_suite_focus=true.

@jackton1
Copy link
Member

jackton1 commented Nov 12, 2021

@jackton1 jackton1 reopened this Nov 12, 2021
@jackton1 jackton1 reopened this Nov 15, 2021
@jackton1
Copy link
Member

jackton1 commented Nov 15, 2021

Seems I misunderstood the solution, I’ll add support for enabling or disabling the autocrlf setting via a new input which should be available in the latest release.

jackton1 added a commit that referenced this issue Nov 24, 2021
jackton1 added a commit that referenced this issue Nov 24, 2021
* Add input setting for core.autocrlf

Resolves: #101

* Update action.yml

* Update entrypoint.sh

* Update README.md

* Update action.yml
@jackton1
Copy link
Member

@C0ZEN The autocrlf setting should now be available in the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants