-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changed_keys and modified_keys output to handle json and escape_json inputs #1585
fix: changed_keys and modified_keys output to handle json and escape_json inputs #1585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing a fix, could you ensure that the test covers your changes if applicable.
@all-contributors please add @V0lantis for bug |
I've put up a pull request to add @V0lantis! 🎉 |
@all-contributors please add @V0lantis for code |
I've updated the pull request to add @V0lantis! 🎉 |
Thanks @jackton1, hope my Pull request will help you :) |
12a95d9
to
cfba8be
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
…#2416) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tj-actions/changed-files](https://togithub.com/tj-actions/changed-files) | action | patch | `v39.1.0` -> `v39.1.1` | --- ### Release Notes <details> <summary>tj-actions/changed-files (tj-actions/changed-files)</summary> ### [`v39.1.1`](https://togithub.com/tj-actions/changed-files/releases/tag/v39.1.1) [Compare Source](https://togithub.com/tj-actions/changed-files/compare/v39.1.0...v39.1.1) #### What's Changed - Upgraded to v39.1.0 by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1583](https://togithub.com/tj-actions/changed-files/pull/1583) - chore: move variable declaration by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1584](https://togithub.com/tj-actions/changed-files/pull/1584) - chore: Update test.yml by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1586](https://togithub.com/tj-actions/changed-files/pull/1586) - docs: add V0lantis as a contributor for bug by [@​allcontributors](https://togithub.com/allcontributors) in [https://github.com/tj-actions/changed-files/pull/1587](https://togithub.com/tj-actions/changed-files/pull/1587) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1588](https://togithub.com/tj-actions/changed-files/pull/1588) - fix: error with test by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1589](https://togithub.com/tj-actions/changed-files/pull/1589) - fix: changed_keys and modified_keys output to handle json and escape_json inputs by [@​V0lantis](https://togithub.com/V0lantis) in [https://github.com/tj-actions/changed-files/pull/1585](https://togithub.com/tj-actions/changed-files/pull/1585) - chore: add codacy config by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1590](https://togithub.com/tj-actions/changed-files/pull/1590) #### New Contributors - [@​V0lantis](https://togithub.com/V0lantis) made their first contribution in [https://github.com/tj-actions/changed-files/pull/1585](https://togithub.com/tj-actions/changed-files/pull/1585) **Full Changelog**: tj-actions/changed-files@v39...v39.1.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4zIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: repo-jeeves <106431701+repo-jeeves[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tj-actions/changed-files](https://togithub.com/tj-actions/changed-files) | action | minor | `v39.0.3` -> `v39.1.1` | --- ### Release Notes <details> <summary>tj-actions/changed-files (tj-actions/changed-files)</summary> ### [`v39.1.1`](https://togithub.com/tj-actions/changed-files/releases/tag/v39.1.1) [Compare Source](https://togithub.com/tj-actions/changed-files/compare/v39.1.0...v39.1.1) #### What's Changed - Upgraded to v39.1.0 by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1583](https://togithub.com/tj-actions/changed-files/pull/1583) - chore: move variable declaration by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1584](https://togithub.com/tj-actions/changed-files/pull/1584) - chore: Update test.yml by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1586](https://togithub.com/tj-actions/changed-files/pull/1586) - docs: add V0lantis as a contributor for bug by [@​allcontributors](https://togithub.com/allcontributors) in [https://github.com/tj-actions/changed-files/pull/1587](https://togithub.com/tj-actions/changed-files/pull/1587) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1588](https://togithub.com/tj-actions/changed-files/pull/1588) - fix: error with test by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1589](https://togithub.com/tj-actions/changed-files/pull/1589) - fix: changed_keys and modified_keys output to handle json and escape_json inputs by [@​V0lantis](https://togithub.com/V0lantis) in [https://github.com/tj-actions/changed-files/pull/1585](https://togithub.com/tj-actions/changed-files/pull/1585) - chore: add codacy config by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1590](https://togithub.com/tj-actions/changed-files/pull/1590) #### New Contributors - [@​V0lantis](https://togithub.com/V0lantis) made their first contribution in [https://github.com/tj-actions/changed-files/pull/1585](https://togithub.com/tj-actions/changed-files/pull/1585) **Full Changelog**: tj-actions/changed-files@v39...v39.1.1 ### [`v39.1.0`](https://togithub.com/tj-actions/changed-files/releases/tag/v39.1.0) [Compare Source](https://togithub.com/tj-actions/changed-files/compare/v39.0.3...v39.1.0) ##### What's Changed - Upgraded to v39.0.3 by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1577](https://togithub.com/tj-actions/changed-files/pull/1577) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1578](https://togithub.com/tj-actions/changed-files/pull/1578) - chore(deps): update typescript-eslint monorepo to v6.7.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1580](https://togithub.com/tj-actions/changed-files/pull/1580) - feat: add support for returning YAML keys for paths that have changed by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1581](https://togithub.com/tj-actions/changed-files/pull/1581) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1582](https://togithub.com/tj-actions/changed-files/pull/1582) **Full Changelog**: tj-actions/changed-files@v39...v39.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Yash-Garg/qBittorrent-Manager). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Even though the new feature is almost fine, I added an update which makes it perfect in our use case.