Try fix app docker image

facebook/react#24928 (comment)
tix-factory · Mar 18, 2023 · ebffd88 · ebffd88
1 parent b3af134
commit ebffd88
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 24 deletions.
diff --git a/libs/js/push-notifications/package-lock.json b/libs/js/push-notifications/package-lock.json
diff --git a/libs/js/push-notifications/package.json b/libs/js/push-notifications/package.json
@@ -7,7 +7,7 @@
   "scripts": {
     "build": "tsc"
   },
-  "dependencies": {
+  "peerDependencies": {
     "@types/react": "^18.0.28",
     "react": "^18.2.0"
   },

diff --git a/services/app/Dockerfile b/services/app/Dockerfile
@@ -1,20 +1,27 @@
 # Setup runtime images
 FROM node:19 AS base
 
-# Setup build image
-FROM node:19 AS build
+# Setup image to build the published module with
+FROM node:19 AS build-module
 
-# Copy files over
-COPY ./services/app ./services/app
+# Copy the files over
 COPY ./libs/js ./libs/js
 
-# Install the module packages
+# Install the packages
 WORKDIR /libs/js/push-notifications
 RUN npm ci
 
 # Build the module
 RUN npm run build
 
+# Setup build image
+FROM node:19 AS build
+
+# Copy files over
+COPY --from=build-module /libs/js/push-notifications/dist /libs/js/push-notifications/dist
+COPY --from=build-module /libs/js/push-notifications/package.json /libs/js/push-notifications/package.json
+COPY ./services/app ./services/app
+
 # Install the packages
 WORKDIR /services/app
 RUN npm ci

diff --git a/services/app/package-lock.json b/services/app/package-lock.json